Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ab/add zarr timeseries #538

Merged
merged 30 commits into from
Jul 11, 2023
Merged

Ab/add zarr timeseries #538

merged 30 commits into from
Jul 11, 2023

Conversation

abarciauskas-bgse
Copy link
Contributor

This PR adds a component for Zarr timeseries layers which is similar too (but much simpler than) the raster timeseries component.

Right now, the only Zarr datasets available via STAC are in the dev version of the catalog, which is why I temporarily point the STAC API URL to the dev stack. This change (to the STAC API URL) should not be merged. We should first determine if that zarr dataset in dev will be promoted to staging and / or a resolution to this ADR on including external datasets: https:/NASA-IMPACT/veda-architecture/pull/258

@netlify
Copy link

netlify bot commented May 15, 2023

Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit f71364a
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/64ac48d048e0f9000807a9a8
😎 Deploy Preview https://deploy-preview-538--veda-ui.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mapboxId: 'cldu1cb8f00ds01p6gi583w1m',
thumbnailUrl: `https://api.mapbox.com/styles/v1/covid-nasa/cldac5c2c003k01oebmavw4q3/static/-9.14,38.7,10.5,0/480x320?access_token=${process.env.MAPBOX_TOKEN}`
mapboxId: 'ckb01h6f10bn81iqg98ne0i2y',
thumbnailUrl: `https://api.mapbox.com/styles/v1/covid-nasa/ckb01h6f10bn81iqg98ne0i2y/static/-9.14,38.7,10.5,0/480x320?access_token=${process.env.MAPBOX_TOKEN}`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this change is necessary to have things working locally but apparently I needed it to get things working. Should it be updated?

@@ -0,0 +1,44 @@
---
id: oco2-geos-l3-daily
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just for demonstration purposes, not sure this dataset or its configuration will end up in the dashboard and if so it would go in veda-config anyways

@danielfdsilva
Copy link
Collaborator

@abarciauskas-bgse Made some small changes and rebased on top of main.

Changes:

  • The layer components now get the full layer data instead of just properties. Each component then uses what needs
  • Fixed some TS typings

@danielfdsilva
Copy link
Collaborator

Will fix #166

Copy link
Collaborator

@danielfdsilva danielfdsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be good to go once the data makes it to the production environment.

@abarciauskas-bgse abarciauskas-bgse marked this pull request as draft June 5, 2023 06:25
@abarciauskas-bgse
Copy link
Contributor Author

I will update this PR to resolve conflicts soon, but more immediately need to address the titiler deployment returning an internal server error (with no logs at this time)

@danielfdsilva
Copy link
Collaborator

@abarciauskas-bgse Is there any update on this? Are we planning to include this in the current format?

@abarciauskas-bgse abarciauskas-bgse marked this pull request as ready for review July 5, 2023 19:49
@abarciauskas-bgse
Copy link
Contributor Author

@danielfdsilva this should be good to merge. I have updated the branch with latest changes and tested locally. Waiting on the netlify preview at the moment.

@abarciauskas-bgse
Copy link
Contributor Author

@danielfdsilva it looks like there are some lint and ts-check errors unrelated to this PR - can you help me resolve them? Any advice on how to avoid this in the future would be appreciated.

Copy link
Collaborator

@danielfdsilva danielfdsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abarciauskas-bgse Made a couple of changes to simplifying the layer data handling and fix the typing issues. I'd say it is good to go.

@abarciauskas-bgse
Copy link
Contributor Author

Thank you @danielfdsilva

@j08lue @anayeaye I would like to setup some automated alerts in case the xarray titiler goes down but then I think we should go ahead and add the zarr dataset to the dashboard (see https:/NASA-IMPACT/veda-ui/blob/ab/add-zarr-timeseries/mock/datasets/oco2-geos-l3-daily.data.mdx) to demonstrate the capability, what do you think?

@abarciauskas-bgse abarciauskas-bgse merged commit 8c636ac into main Jul 11, 2023
8 checks passed
@abarciauskas-bgse abarciauskas-bgse deleted the ab/add-zarr-timeseries branch July 11, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants